]> git.baikalelectronics.ru Git - kernel.git/commit
flow_dissector: Cleanup control flow
authorTom Herbert <tom@quantonium.net>
Fri, 1 Sep 2017 21:04:11 +0000 (14:04 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 Sep 2017 18:40:08 +0000 (11:40 -0700)
commit24f62265d245cf65ee88075fe7b9523bef7cbf7e
treeeb04848adab6ac341a0b9dcbcd5e646ccf28e769
parent298c686000f79f4c821f6be8064efbbeb8b2e9ac
flow_dissector: Cleanup control flow

__skb_flow_dissect is riddled with gotos that make discerning the flow,
debugging, and extending the capability difficult. This patch
reorganizes things so that we only perform goto's after the two main
switch statements (no gotos within the cases now). It also eliminates
several goto labels so that there are only two labels that can be target
for goto.

Reported-by: Alexander Popov <alex.popov@linux.com>
Signed-off-by: Tom Herbert <tom@quantonium.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/flow_dissector.h
net/core/flow_dissector.c