]> git.baikalelectronics.ru Git - kernel.git/commit
blk-iocost: don't ignore vrate_min on QD contention
authorTejun Heo <tj@kernel.org>
Fri, 23 Apr 2021 01:54:28 +0000 (21:54 -0400)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Apr 2021 12:44:18 +0000 (06:44 -0600)
commit24e52bcf519e37d989d534f33246f8bb54d51ee7
tree752b0dc8602de6580ee5ab5699662c6814ea87d1
parent9156f7c02493e61ecfc309900e3a93d167c8b6f6
blk-iocost: don't ignore vrate_min on QD contention

ioc_adjust_base_vrate() ignored vrate_min when rq_wait_pct indicates that
there is QD contention. The reasoning was that QD depletion always reliably
indicates device saturation and thus it's safe to override user specified
vrate_min. However, this sometimes leads to unnecessary throttling,
especially on really fast devices, because vrate adjustments have delays and
inertia. It also confuses users because the behavior violates the explicitly
specified configuration.

This patch drops the special case handling so that vrate_min is always
applied.

Signed-off-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/YIIo1HuyNmhDeiNx@slm.duckdns.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iocost.c