]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in st_probe
authorJia-Ju Bai <baijiaju1990@gmail.com>
Tue, 10 Apr 2018 12:37:59 +0000 (20:37 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 20 Apr 2018 23:14:37 +0000 (19:14 -0400)
commit24a45f60122daab18552fcf334a2048aac8d46a9
tree2130ad081ce9e1a363af077d6dc7898b7acb77a0
parentabfe30d3be540a001cf3387c19712bfb145c128c
scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in st_probe

st_probe() is never called in atomic context. st_probe() is only set as
".probe" in struct scsi_driver.

Despite never getting called from atomic context, st_probe() calls
kzalloc() with GFP_ATOMIC, which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which
can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/st.c