]> git.baikalelectronics.ru Git - kernel.git/commit
MIPS: Remove repetitive increase irq_err_count
authorhuhai <huhai@kylinos.cn>
Fri, 10 Jun 2022 11:14:20 +0000 (19:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jun 2022 07:03:24 +0000 (09:03 +0200)
commit247a0d6769835c550d8acfb22f1b449ea917581e
tree19e82581734da8df6ec0b1e268928271c6a88dc0
parent74b28b795c1c138b8089c4e897cde7201cf877e3
MIPS: Remove repetitive increase irq_err_count

[ Upstream commit 51f191c59592f818b8def704727c43091b39477e ]

commit ab4fd97bb851 ("[PATCH] mips: update IRQ handling for vr41xx") added
a function irq_dispatch, and it'll increase irq_err_count when the get_irq
callback returns a negative value, but increase irq_err_count in get_irq
was not removed.

And also, modpost complains once gpio-vr41xx drivers become modules.
  ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!

So it would be a good idea to remove repetitive increase irq_err_count in
get_irq callback.

Fixes: cc5be02f60c6 ("MIPS: Update VR41xx GPIO driver to use gpiolib")
Fixes: ab4fd97bb851 ("[PATCH] mips: update IRQ handling for vr41xx")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: huhai <huhai@kylinos.cn>
Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/mips/vr41xx/common/icu.c
drivers/gpio/gpio-vr41xx.c