]> git.baikalelectronics.ru Git - kernel.git/commit
drm/tve200: Stabilize enable/disable
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 20 Aug 2020 20:31:44 +0000 (22:31 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 3 Sep 2020 19:14:09 +0000 (21:14 +0200)
commit246d6edc3540c5f89aec06945d9871a90d36602d
tree2cd32b485608adeaab8d7ffc17b2711676c6cbec
parentb8a857e354281ffa142d69e77e7b11662b4e5332
drm/tve200: Stabilize enable/disable

The TVE200 will occasionally print a bunch of lost interrupts
and similar dmesg messages, sometimes during boot and sometimes
after disabling and coming back to enablement. This is probably
because the hardware is left in an unknown state by the boot
loader that displays a logo.

This can be fixed by bringing the controller into a known state
by resetting the controller while enabling it. We retry reset 5
times like the vendor driver does. We also put the controller
into reset before de-clocking it and clear all interrupts before
enabling the vblank IRQ.

This makes the video enable/disable/enable cycle rock solid
on the D-Link DIR-685. Tested extensively.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org
Link: https://patchwork.freedesktop.org/patch/msgid/20200820203144.271081-1-linus.walleij@linaro.org
drivers/gpu/drm/tve200/tve200_display.c