]> git.baikalelectronics.ru Git - kernel.git/commit
watchdog: sbsa: only use 32-bit accessors
authorJamie Iles <quic_jiles@quicinc.com>
Fri, 3 Sep 2021 11:21:01 +0000 (12:21 +0100)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Tue, 26 Oct 2021 18:22:50 +0000 (20:22 +0200)
commit24433335b46af0595e99c8d1e1b6135afcc39c73
tree572ff53e2446f7478f133b3298d11444f6500ec8
parente68321e6ce265e180302453ea81ca8edc749da06
watchdog: sbsa: only use 32-bit accessors

SBSA says of the generic watchdog:

  All registers are 32 bits in size and should be accessed using 32-bit
  reads and writes. If an access size other than 32 bits is used then
  the results are IMPLEMENTATION DEFINED.

and for qemu, the implementation will only allow 32-bit accesses
resulting in a synchronous external abort when configuring the watchdog.
Use lo_hi_* accessors rather than a readq/writeq.

Fixes: bfa20b6092f4 ("watchdog: sbsa: Support architecture version 1")
Signed-off-by: Jamie Iles <quic_jiles@quicinc.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Link: https://lore.kernel.org/r/20210903112101.493552-1-quic_jiles@quicinc.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/sbsa_gwdt.c