]> git.baikalelectronics.ru Git - kernel.git/commit
spi: spi-fsl-dspi: Fix lockup if device is shutdown during SPI transfer
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 22 Jun 2020 11:05:41 +0000 (13:05 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jun 2020 12:50:27 +0000 (13:50 +0100)
commit23a6a9c1fc3a053cafa3741cef07afd82e6fccfe
tree4daab1b8c0efcf596f9fc176d2026d28c70dbfb8
parent99113ed06dc2241732cb3df84236b90381b23d06
spi: spi-fsl-dspi: Fix lockup if device is shutdown during SPI transfer

During shutdown, the driver should unregister the SPI controller
and stop the hardware.  Otherwise the dspi_transfer_one_message() could
wait on completion infinitely.

Additionally, calling spi_unregister_controller() first in device
shutdown reverse-matches the probe function, where SPI controller is
registered at the end.

Fixes: 28ea68cd61ff ("spi: spi-fsl-dspi: Adding shutdown hook")
Reported-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200622110543.5035-2-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-dspi.c