]> git.baikalelectronics.ru Git - kernel.git/commit
s390/qeth: fix error handling for isolation mode cmds
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 17 Jun 2020 14:54:52 +0000 (16:54 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Jun 2020 03:27:42 +0000 (20:27 -0700)
commit230ca236a7c120493a854845c9db2e1fda3155a4
tree9775f9d9f5f2fec7cb84e6a998ce2491b49a1465
parent9ebc76e0efede3cf688c66dc7ba73db634fa0c87
s390/qeth: fix error handling for isolation mode cmds

Current(?) OSA devices also store their cmd-specific return codes for
SET_ACCESS_CONTROL cmds into the top-level cmd->hdr.return_code.
So once we added stricter checking for the top-level field a while ago,
none of the error logic that rolls back the user's configuration to its
old state is applied any longer.

For this specific cmd, go back to the old model where we peek into the
cmd structure even though the top-level field indicated an error.

Fixes: d3fb3325e754 ("s390/qeth: fix error handling in adapter command callbacks")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core_main.c