]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vc4: plane: Remove subpixel positioning check
authorDom Cobley <popcornmix@gmail.com>
Mon, 13 Jun 2022 14:47:31 +0000 (16:47 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:24 +0000 (14:23 +0200)
commit22ec11b86314fc84a051d1259c243954a42069ce
treeffb99d96cecbcf195dfaa95c4aa80fccc189234e
parentfffa2ff2f6c6bd190069786ae1b9b20834967bb6
drm/vc4: plane: Remove subpixel positioning check

[ Upstream commit 40168b3b2a51343a095a73101a9d10bae47aef21 ]

There is little harm in ignoring fractional coordinates
(they just get truncated).

Without this:
modetest -M vc4 -F tiles,gradient -s 32:1920x1080-60 -P89@74:1920x1080*.1.1@XR24

is rejected. We have the same issue in Kodi when trying to
use zoom options on video.

Note: even if all coordinates are fully integer. e.g.
src:[0,0,1920,1080] dest:[-10,-10,1940,1100]

it will still get rejected as drm_atomic_helper_check_plane_state
uses drm_rect_clip_scaled which transforms this to fractional src coords

Fixes: 91c5f61694f7 ("drm/vc4: Add support for scaling of display planes.")
Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Link: https://lore.kernel.org/r/20220613144800.326124-5-maxime@cerno.tech
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/vc4/vc4_plane.c