]> git.baikalelectronics.ru Git - kernel.git/commit
libceph: fix alloc_msg_with_page_vector() memory leaks
authorIlya Dryomov <idryomov@gmail.com>
Tue, 10 Mar 2020 15:19:01 +0000 (16:19 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2020 13:11:02 +0000 (15:11 +0200)
commit227febe966f3408f8077e0522d8560ce780bc7aa
tree7624651dfb6b7e5598488c31c85326a3130c61ec
parent967937e31c86483c836635021a3eb178e202555c
libceph: fix alloc_msg_with_page_vector() memory leaks

commit cc5392af77440b7d90a793393dbd09b1350ad5d9 upstream.

Make it so that CEPH_MSG_DATA_PAGES data item can own pages,
fixing a bunch of memory leaks for a page vector allocated in
alloc_msg_with_page_vector().  Currently, only watch-notify
messages trigger this allocation, and normally the page vector
is freed either in handle_watch_notify() or by the caller of
ceph_osdc_notify().  But if the message is freed before that
(e.g. if the session faults while reading in the message or
if the notify is stale), we leak the page vector.

This was supposed to be fixed by switching to a message-owned
pagelist, but that never happened.

Fixes: 536a8fc07435 ("libceph: support for sending notifies")
Reported-by: Roman Penyaev <rpenyaev@suse.de>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Roman Penyaev <rpenyaev@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/ceph/messenger.h
net/ceph/messenger.c
net/ceph/osd_client.c