]> git.baikalelectronics.ru Git - kernel.git/commit
scsi/NCR5380: fix and standardize NDEBUG macros
authorFinn Thain <fthain@telegraphics.com.au>
Tue, 18 Mar 2014 00:42:21 +0000 (11:42 +1100)
committerChristoph Hellwig <hch@lst.de>
Wed, 28 May 2014 10:10:43 +0000 (12:10 +0200)
commit227a73c50dfb9e96e2f2925b1874af88f86cccf9
tree7b40861443beafa31008301b81cc8a1588e18396
parent18c85180b7ba9a9bf4585647655d30bae5a6be5a
scsi/NCR5380: fix and standardize NDEBUG macros

All three NCR5380 core driver implementations share the same NCR5380.h
header file so they need to agree on certain macro definitions.

The flag bit used by the NDEBUG_MERGING macro in atari_NCR5380 and
sun3_NCR5380 collides with the bit used by NDEBUG_LISTS.

Moreover, NDEBUG_ABORT appears in NCR5380.c so it should be defined in
NCR5380.h rather than in each of the many drivers using that core.

An undefined NDEBUG_ABORT macro caused compiler errors and led to dodgy
workarounds in the core driver that can now be removed.
(See commits 0fc2b771d80a47009dd3c7c2e3247830186a6b8d and
2248d9211ab5e72717505a741c976bdd0beeb02c.)

Move all of the NDEBUG_ABORT, NDEBUG_TAGS and NDEBUG_MERGING macro
definitions into NCR5380.h where all the other NDEBUG macros live.

Also, incorrect "#ifdef NDEBUG" becomes "#if NDEBUG" to fix the warning:
drivers/scsi/mac_scsi.c: At top level:
drivers/scsi/NCR5380.c:418: warning: 'NCR5380_print' defined but not used
drivers/scsi/NCR5380.c:459: warning: 'NCR5380_print_phase' defined but not used

The debugging code is now enabled when NDEBUG != 0.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Acked-by: Sam Creasey <sammy@sammy.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/NCR5380.c
drivers/scsi/NCR5380.h
drivers/scsi/atari_NCR5380.c
drivers/scsi/atari_scsi.c
drivers/scsi/dtc.c
drivers/scsi/mac_scsi.c
drivers/scsi/sun3_NCR5380.c
drivers/scsi/sun3_scsi.c
drivers/scsi/sun3_scsi_vme.c