]> git.baikalelectronics.ru Git - kernel.git/commit
x86: Flush TLB if PGD entry is changed in i386 PAE mode
authorShaohua Li <shaohua.li@intel.com>
Wed, 16 Mar 2011 03:37:29 +0000 (11:37 +0800)
committerIngo Molnar <mingo@elte.hu>
Fri, 18 Mar 2011 10:44:01 +0000 (11:44 +0100)
commit2254275359816637b195374ed6a6b07bd9d8a89e
tree3f1e39b63111e06e2c213c6a0b1c5176e81a4ff9
parentc4697e631685e48b612d314bbfef846a3537a5a0
x86: Flush TLB if PGD entry is changed in i386 PAE mode

According to intel CPU manual, every time PGD entry is changed in i386 PAE
mode, we need do a full TLB flush. Current code follows this and there is
comment for this too in the code.

But current code misses the multi-threaded case. A changed page table
might be used by several CPUs, every such CPU should flush TLB. Usually
this isn't a problem, because we prepopulate all PGD entries at process
fork. But when the process does munmap and follows new mmap, this issue
will be triggered.

When it happens, some CPUs keep doing page faults:

  http://marc.info/?l=linux-kernel&m=129915020508238&w=2

Reported-by: Yasunori Goto<y-goto@jp.fujitsu.com>
Tested-by: Yasunori Goto<y-goto@jp.fujitsu.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Shaohua Li<shaohua.li@intel.com>
Cc: Mallick Asit K <asit.k.mallick@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>
Cc: stable <stable@kernel.org>
LKML-Reference: <1300246649.2337.95.camel@sli10-conroe>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/pgtable-3level.h
arch/x86/mm/pgtable.c