]> git.baikalelectronics.ru Git - kernel.git/commit
infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_add_mqh_4
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 11 Apr 2018 07:32:25 +0000 (15:32 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 18 Apr 2018 01:57:11 +0000 (19:57 -0600)
commit222d366a408c6d7737d7b1074b0af3f994e730a1
tree9fbe6b51575f396595115ee250c8d0c7b61d0fec
parentc521ad4d9b68892f5611c4a7706a4c8c24dc6f83
infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_add_mqh_4

i40iw_add_mqh_4() is never called in atomic context, because it
calls rtnl_lock() that can sleep.

Despite never getting called from atomic context,
i40iw_add_mqh_4() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/i40iw/i40iw_cm.c