]> git.baikalelectronics.ru Git - kernel.git/commit
serial: 8250_bcm2835aux: Allocate uart_8250_port on stack
authorLukas Wunner <lukas@wunner.de>
Thu, 16 Jan 2020 12:14:04 +0000 (13:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Jan 2020 09:22:30 +0000 (10:22 +0100)
commit2205151965e986575768af8bed4b91d17ec665d2
treea79800f2d9253b354df93d43b0ded8d65a0a709a
parent97a7b63aa212d3c26c0de2f918e43e855b06834c
serial: 8250_bcm2835aux: Allocate uart_8250_port on stack

The bcm2835aux UART driver stores a struct uart_8250_port in its private
data even though it's only passed once to serial8250_register_8250_port()
(which copies all relevant data) and becomes obsolete afterwards.
Allocate the struct on the stack instead for simplicity and to conserve
memory.

The driver also initializes a spinlock in the struct which is never used.
Drop that as well.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: Martin Sperl <kernel@martin.sperl.org>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Link: https://lore.kernel.org/r/421d3aed4c34cc8447ac9c26c320961f1b787f11.1579175223.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_bcm2835aux.c