]> git.baikalelectronics.ru Git - kernel.git/commit
firmware: arm_scpi: Fix string overflow in SCPI genpd driver
authorSudeep Holla <sudeep.holla@arm.com>
Thu, 9 Dec 2021 12:04:56 +0000 (12:04 +0000)
committerArnd Bergmann <arnd@arndb.de>
Mon, 13 Dec 2021 14:17:37 +0000 (15:17 +0100)
commit21fbf8f774aa583088cced421a8c7b72a17510d4
treec1c42564eaab0032d755d246a66b4ce7fed9542f
parent02da3312b6c7a386b5b1e597c6c1b63a860eafd1
firmware: arm_scpi: Fix string overflow in SCPI genpd driver

Without the bound checks for scpi_pd->name, it could result in the buffer
overflow when copying the SCPI device name from the corresponding device
tree node as the name string is set at maximum size of 30.

Let us fix it by using devm_kasprintf so that the string buffer is
allocated dynamically.

Fixes: 2545adcd830d ("firmware: scpi: add device power domain support using genpd")
Reported-by: Pedro Batista <pedbap.g@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Cc: stable@vger.kernel.org
Cc: Cristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20211209120456.696879-1-sudeep.holla@arm.com'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/firmware/scpi_pm_domain.c