]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "tcp: change pingpong threshold to 3"
authorWei Wang <weiwan@google.com>
Thu, 21 Jul 2022 20:44:04 +0000 (20:44 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Aug 2022 10:03:45 +0000 (12:03 +0200)
commit21b512de8b5ec62427c61a98b587002f9f82b616
treea790c21ea1a260f781e5206c2d3c8d32cdc636fb
parenteadff72a79cc5551b284d37a037d9ee8b4494b77
Revert "tcp: change pingpong threshold to 3"

commit 50b6b74acb305c445e0798100fd3a75ca6367b7b upstream.

This reverts commit f8c8f53658928f7ed32acb954b15ca82a906e085.

This to-be-reverted commit was meant to apply a stricter rule for the
stack to enter pingpong mode. However, the condition used to check for
interactive session "before(tp->lsndtime, icsk->icsk_ack.lrcvtime)" is
jiffy based and might be too coarse, which delays the stack entering
pingpong mode.
We revert this patch so that we no longer use the above condition to
determine interactive session, and also reduce pingpong threshold to 1.

Fixes: f8c8f5365892 ("tcp: change pingpong threshold to 3")
Reported-by: LemmyHuang <hlm3280@163.com>
Suggested-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Wei Wang <weiwan@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220721204404.388396-1-weiwan@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/net/inet_connection_sock.h
net/ipv4/tcp_output.c