]> git.baikalelectronics.ru Git - kernel.git/commit
net: ethernet: mtk_eth_soc: fix error handling in mtk_open()
authorLiu Jian <liujian56@huawei.com>
Thu, 17 Nov 2022 11:13:56 +0000 (19:13 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 19 Nov 2022 03:33:05 +0000 (19:33 -0800)
commit21615c6308a04a414d183a084cadbf9a47e0f6e2
treecfe3173d8a26a96306679266a89a06415dbd6b13
parent2c3cf8c2d6f9bb0e5877d91283a08c2e304c34e1
net: ethernet: mtk_eth_soc: fix error handling in mtk_open()

If mtk_start_dma() fails, invoke phylink_disconnect_phy() to perform
cleanup. phylink_disconnect_phy() contains the put_device action. If
phylink_disconnect_phy is not performed, the Kref of netdev will leak.

Fixes: fcc7dd9fe410 ("net: ethernet: mediatek: Add basic PHYLINK support")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/20221117111356.161547-1-liujian56@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c