]> git.baikalelectronics.ru Git - kernel.git/commit
MIPS: c-r4k: Fix size calc when avoiding IPIs for small icache flushes
authorPaul Burton <paul.burton@imgtec.com>
Mon, 5 Sep 2016 14:24:54 +0000 (15:24 +0100)
committerRalf Baechle <ralf@linux-mips.org>
Tue, 13 Sep 2016 15:37:20 +0000 (17:37 +0200)
commit20ee0c0ede1e85a464a7ecc6181291b0796aef7f
treedc566a74be301230c9da20dd939df2d8a6efe84b
parentf581b6bc2e4d7492180cf7789205dd7204a79cc9
MIPS: c-r4k: Fix size calc when avoiding IPIs for small icache flushes

Commit 0f580912b876 ("MIPS: c-r4k: Avoid small flush_icache_range SMP
calls") adds checks to force use of hit-type cache ops for small icache
flushes where they are globalised & index-type cache ops aren't, in
order to avoid the overhead of IPIs in those cases. However it
calculated the size of the region being flushed incorrectly, subtracting
the end address from the start address rather than the reverse. This
would have led to an overflow with size wrapping round to some large
value, and likely to the special case for avoiding IPIs not actually
being hit.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: James Hogan <james.hogan@imgtec.com>
Fixes: 0f580912b876 ("MIPS: c-r4k: Avoid small flush_icache_range SMP calls")
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Cc: Huacai Chen <chenhc@lemote.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/14211/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/mm/c-r4k.c