]> git.baikalelectronics.ru Git - kernel.git/commit
f2fs: fix a redundant call to f2fs_balance_fs if an error occurs
authorColin Ian King <colin.king@canonical.com>
Thu, 4 Mar 2021 09:21:18 +0000 (09:21 +0000)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 12 Mar 2021 21:16:44 +0000 (13:16 -0800)
commit20633509dfa43ce7f6f99e3877258cf384104298
tree7aa5e0577b573c243bacfaa529be42e57736235a
parentb0fe20458afa33ead7232b2f158d6ad2a645ada9
f2fs: fix a redundant call to f2fs_balance_fs if an error occurs

The  uninitialized variable dn.node_changed does not get set when a
call to f2fs_get_node_page fails.  This uninitialized value gets used
in the call to f2fs_balance_fs() that may or not may not balances
dirty node and dentry pages depending on the uninitialized state of
the variable. Fix this by only calling f2fs_balance_fs if err is
not set.

Thanks to Jaegeuk Kim for suggesting an appropriate fix.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 2629058fb8d9 ("f2fs: call f2fs_balance_fs only when node was changed")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/inline.c