]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: cirrus: Add helper function for reading the device ID
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Mon, 10 May 2021 13:13:48 +0000 (14:13 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 10 May 2021 16:27:46 +0000 (17:27 +0100)
commit2053b0e08d5ad73cea066c43224aa2c48ad4246e
tree8226a4045bcc1329be55866dcd54b2b950797522
parent2b8cc65dcacfd735385a2e0eeb4d95ce6797df64
ASoC: cirrus: Add helper function for reading the device ID

Many of the older Cirrus devices share very similar code for reading the
device ID, and frequently this code is generating cppcheck warnings such
as:

sound/soc/codecs/cs42l42.c:1886:6: style: Variable 'ret' is reassigned
a value before the old one has been used. [redundantAssignment]
 ret = regmap_read(cs42l42->regmap, CS42L42_DEVID_CD, &reg);

Add a small helper function that older Cirrus devices can use to read
the device ID, which should help correct these issues.

Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210510131357.17170-2-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cirrus_legacy.h [new file with mode: 0644]