]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: x86: fix WARN_ON check of an unsigned less than zero
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 12 Feb 2020 12:27:10 +0000 (13:27 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 12 Feb 2020 19:09:46 +0000 (20:09 +0100)
commit1f80ac7f43610e6dd201697d4cf575f5ad240ad9
treef6c9f4f50e27e54732ba5767e6d29af1e02924a4
parent35be3b384e72762352798eda020609873a5040c9
KVM: x86: fix WARN_ON check of an unsigned less than zero

The check cpu->hv_clock.system_time < 0 is redundant since system_time
is a u64 and hence can never be less than zero.  But what was actually
meant is to check that the result is positive, since kernel_ns and
v->kvm->arch.kvmclock_offset are both s64.

Reported-by: Colin King <colin.king@canonical.com>
Suggested-by: Sean Christopherson <sean.j.christopherson@intel.com>
Addresses-Coverity: ("Macro compares unsigned to 0")
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/x86.c