]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: dwc-qos: Disable split header for Tegra194
authorJon Hunter <jonathanh@nvidia.com>
Wed, 6 Jul 2022 08:39:13 +0000 (09:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Jul 2022 18:59:20 +0000 (20:59 +0200)
commit1f7bbbf8c2a43b91b7311b59c0d0166772415b40
treebb0a928a000b3dc1c65afcf4cdc7c6f88ca24a1b
parentba7bbf16439cf9c32105c22596ce340aeb785f05
net: stmmac: dwc-qos: Disable split header for Tegra194

[ Upstream commit cfc14ebbf901cc3f3c9dc3f30f5a95c76b4a891c ]

There is a long-standing issue with the Synopsys DWC Ethernet driver
for Tegra194 where random system crashes have been observed [0]. The
problem occurs when the split header feature is enabled in the stmmac
driver. In the bad case, a larger than expected buffer length is
received and causes the calculation of the total buffer length to
overflow. This results in a very large buffer length that causes the
kernel to crash. Why this larger buffer length is received is not clear,
however, the feedback from the NVIDIA design team is that the split
header feature is not supported for Tegra194. Therefore, disable split
header support for Tegra194 to prevent these random crashes from
occurring.

[0] https://lore.kernel.org/linux-tegra/b0b17697-f23e-8fa5-3757-604a86f3a095@nvidia.com/

Fixes: 5c73dc61d53a ("net: stmmac: Add Split Header support and enable it in XGMAC cores")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20220706083913.13750-1-jonathanh@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c