]> git.baikalelectronics.ru Git - kernel.git/commit
pinctrl: baytrail: Debounce register is one per community
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 26 Jan 2017 17:24:08 +0000 (19:24 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 30 Jan 2017 14:48:15 +0000 (15:48 +0100)
commit1f7922662ed875580d14839c42e49f0f28d2c6f8
tree4c8718b1130c3a4c89d9b53c404c25ae592db6fe
parent1a50191f7e51245bc6fd04c4df8bd0609f3d11f4
pinctrl: baytrail: Debounce register is one per community

Debounce value is set globally per community. Otherwise user will easily
get a kernel crash when they start using the feature:

BUG: unable to handle kernel paging request at ffffc900003be000
IP: byt_gpio_dbg_show+0xa9/0x430

Make it clear in byt_gpio_reg().

Note that this fix just prevents kernel to crash, but doesn't make any
difference to the existing logic. It means the last caller will win the
trade and debounce value will be configured accordingly. The actual
logic fix needs to be thought about and it's not as important as crash
fix. That's why the latter goes separately and right now.

Fixes: 2936d9bc31a5 ("pinctrl: baytrail: Add debounce configuration")
Cc: Cristina Ciocan <cristina.ciocan@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/intel/pinctrl-baytrail.c