]> git.baikalelectronics.ru Git - kernel.git/commit
stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
authorGONG, Ruiqi <gongruiqi1@huawei.com>
Wed, 29 Jun 2022 06:04:23 +0000 (14:04 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:10 +0000 (14:23 +0200)
commit1f5e48241407e0e068dfcf72022ab0f180a10e8d
tree4fae91d83f55d3fe5cb19e49c30345c01428948d
parentf51ce62529c6fea019e378589db09e73ebe063d0
stack: Declare {randomize_,}kstack_offset to fix Sparse warnings

[ Upstream commit 8902b1549811b01e3f1dc4510f0bc591634c7e65 ]

Fix the following Sparse warnings that got noticed when the PPC-dev
patchwork was checking another patch (see the link below):

init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?

Which in fact are triggered on all architectures that have
HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
etc).

Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Fixes: fdad94d4a5fc ("stack: Optionally randomize kernel stack offset each syscall")
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220629060423.2515693-1-gongruiqi1@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
init/main.c