]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Only access SFC_DONE when media domain is not fused off
authorMatt Roper <matthew.d.roper@intel.com>
Fri, 6 Aug 2021 17:41:30 +0000 (10:41 -0700)
committerMatt Roper <matthew.d.roper@intel.com>
Wed, 11 Aug 2021 20:59:42 +0000 (13:59 -0700)
commit1ea283219749316921eb57e6d782824a4ab7de4c
tree563f2ec16df168a38f2459931d8823d40720d451
parenteeb78fe7d4043fe82750cd844f18c448a2b844f6
drm/i915: Only access SFC_DONE when media domain is not fused off

The SFC_DONE register lives within the corresponding VD0/VD2/VD4/VD6
forcewake domain and is not accessible if the vdbox in that domain is
fused off and the forcewake is not initialized.

This mistake went unnoticed because until recently we were using the
wrong register offset for the SFC_DONE register; once the register
offset was corrected, we started hitting errors like

  <4> [544.989065] i915 0000:cc:00.0: Uninitialized forcewake domain(s) 0x80 accessed at 0x1ce000

on parts with fused-off vdbox engines.

Fixes: 75a8b786e900 ("drm/i915/tgl: Add SFC instdone to error state")
Fixes: 328445859bd9 ("drm/i915: Correct SFC_DONE register offset")
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210806174130.1058960-1-matthew.d.roper@intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
drivers/gpu/drm/i915/i915_gpu_error.c