]> git.baikalelectronics.ru Git - kernel.git/commit
riscv: dts: microchip: correct L2 cache interrupts
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Wed, 17 Aug 2022 13:25:21 +0000 (15:25 +0200)
committerConor Dooley <conor.dooley@microchip.com>
Wed, 17 Aug 2022 17:39:19 +0000 (18:39 +0100)
commit1e9f8e7149fa31ca3afdc5026f33a952bcc1b5c0
tree4cac098408c7c961e0ee544a75aad50e74d9fa21
parent7bc61ea34e2279818c17024fbdca62d66f54f66d
riscv: dts: microchip: correct L2 cache interrupts

The "PolarFire SoC MSS Technical Reference Manual" documents the
following PLIC interrupts:

1 - L2 Cache Controller Signals when a metadata correction event occurs
2 - L2 Cache Controller Signals when an uncorrectable metadata event occurs
3 - L2 Cache Controller Signals when a data correction event occurs
4 - L2 Cache Controller Signals when an uncorrectable data event occurs

This differs from the SiFive FU540 which only has three L2 cache related
interrupts.

The sequence in the device tree is defined by an enum:

    enum {
            DIR_CORR = 0,
            DATA_CORR,
            DATA_UNCORR,
            DIR_UNCORR,
    };

So the correct sequence of the L2 cache interrupts is

    interrupts = <1>, <3>, <4>, <2>;

[Conor]
This manifests as an unusable system if the l2-cache driver is enabled,
as the wrong interrupt gets cleared & the handler prints errors to the
console ad infinitum.

Fixes: 2592ac15b741 ("RISC-V: Initial DTS for Microchip ICICLE board")
CC: stable@vger.kernel.org # 5.15: 6bcff9f9190f: riscv: dts: microchip: mpfs: Group tuples in interrupt properties
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
arch/riscv/boot/dts/microchip/mpfs.dtsi