]> git.baikalelectronics.ru Git - kernel.git/commit
arm64: vdso: Fix Makefile regression
authorVincenzo Frascino <vincenzo.frascino@arm.com>
Mon, 29 Jul 2019 12:54:21 +0000 (13:54 +0100)
committerCatalin Marinas <catalin.marinas@arm.com>
Wed, 31 Jul 2019 17:08:47 +0000 (18:08 +0100)
commit1e84a2f12ae6b010ed8df7dd9cbd4628c4d6347e
tree47b6699e31a7bbf09ba5b489974fcf430f2f364b
parentdb0cdc6802d3fdc83531e3643682b1150435ab5f
arm64: vdso: Fix Makefile regression

Using an old .config in combination with "make oldconfig" can cause
an incorrect detection of the compat compiler:

$ grep CROSS_COMPILE_COMPAT .config
CONFIG_CROSS_COMPILE_COMPAT_VDSO=""

$ make oldconfig && make
arch/arm64/Makefile:58: gcc not found, check CROSS_COMPILE_COMPAT.
Stop.

Accordingly to the section 7.2 of the GNU Make manual "Syntax of
Conditionals", "When the value results from complex expansions of
variables and functions, expansions you would consider empty may
actually contain whitespace characters and thus are not seen as
empty. However, you can use the strip function to avoid interpreting
whitespace as a non-empty value."

Fix the issue adding strip to the CROSS_COMPILE_COMPAT string
evaluation.

Reported-by: Matteo Croce <mcroce@redhat.com>
Tested-by: Matteo Croce <mcroce@redhat.com>
Acked-by: Will Deacon <will@kernel.org>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/Makefile