]> git.baikalelectronics.ru Git - kernel.git/commit
sctp: hold transport instead of assoc in sctp_diag
authorXin Long <lucien.xin@gmail.com>
Mon, 31 Oct 2016 12:32:31 +0000 (20:32 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 31 Oct 2016 20:20:32 +0000 (16:20 -0400)
commit1e6d457b1286283b38ae2190e4b9d66ad96dafbe
tree15e1db16d4528e66c85ede29ffc844cda7607aed
parent45a87cdb96c39cced742f5e2803295c9c60525b1
sctp: hold transport instead of assoc in sctp_diag

In sctp_transport_lookup_process(), Commit 63109f07272e ("sctp: fix
the issue sctp_diag uses lock_sock in rcu_read_lock") moved cb() out
of rcu lock, but it put transport and hold assoc instead, and ignore
that cb() still uses transport. It may cause a use-after-free issue.

This patch is to hold transport instead of assoc there.

Fixes: 63109f07272e ("sctp: fix the issue sctp_diag uses lock_sock in rcu_read_lock")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c