]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: Restrict usage of GPIO chip irq members before initialization
authorShreeya Patel <shreeya.patel@collabora.com>
Mon, 21 Mar 2022 13:32:41 +0000 (19:02 +0530)
committerBartosz Golaszewski <brgl@bgdev.pl>
Mon, 4 Apr 2022 12:41:34 +0000 (14:41 +0200)
commit1e62f68812a0f55c2b10cc83ac194a8ced47d286
treea32186986097a33e9836e207409aacdf72e5c348
parentdbb008736a8c113ef1e12b4e4b4351fac2a15ede
gpio: Restrict usage of GPIO chip irq members before initialization

GPIO chip irq members are exposed before they could be completely
initialized and this leads to race conditions.

One such issue was observed for the gc->irq.domain variable which
was accessed through the I2C interface in gpiochip_to_irq() before
it could be initialized by gpiochip_add_irqchip(). This resulted in
Kernel NULL pointer dereference.

Following are the logs for reference :-

kernel: Call Trace:
kernel:  gpiod_to_irq+0x53/0x70
kernel:  acpi_dev_gpio_irq_get_by+0x113/0x1f0
kernel:  i2c_acpi_get_irq+0xc0/0xd0
kernel:  i2c_device_probe+0x28a/0x2a0
kernel:  really_probe+0xf2/0x460
kernel: RIP: 0010:gpiochip_to_irq+0x47/0xc0

To avoid such scenarios, restrict usage of GPIO chip irq members before
they are completely initialized.

Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Cc: stable@vger.kernel.org
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpiolib.c
include/linux/gpio/driver.h