]> git.baikalelectronics.ru Git - kernel.git/commit
HID: u2fzero: properly handle timeouts in usb_submit_urb
authorAndrej Shadura <andrew.shadura@collabora.co.uk>
Tue, 19 Oct 2021 15:29:17 +0000 (17:29 +0200)
committerJiri Kosina <jkosina@suse.cz>
Wed, 27 Oct 2021 08:17:08 +0000 (10:17 +0200)
commit1e48d869a60bbdae7e93ee1dc7c71bd68d21bd20
treebc67d48a4bcfaea144a0b2736910c329584f317b
parent598452f0586bb3d5eb165e59a2f7714b63e345ed
HID: u2fzero: properly handle timeouts in usb_submit_urb

The wait_for_completion_timeout function returns 0 if timed out or a
positive value if completed. Hence, "less than zero" comparison always
misses timeouts and doesn't kill the URB as it should, leading to
re-sending it while it is active.

Fixes: 311f3595abaa ("HID: add driver for U2F Zero built-in LED and RNG")
Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-u2fzero.c