]> git.baikalelectronics.ru Git - kernel.git/commit
libata: drop WARN from protocol error in ata_sff_qc_issue()
authorTejun Heo <tj@kernel.org>
Mon, 6 Mar 2017 20:26:54 +0000 (15:26 -0500)
committerTejun Heo <tj@kernel.org>
Mon, 6 Mar 2017 20:26:54 +0000 (15:26 -0500)
commit1dfdb8b9ecd4db046716c68abec6a82c4da9bec1
tree359887108dd83d03cae6f70feeadeb6510f3bf02
parentb4064f6a3ccaa7d4bf3947cabb1b23070802b966
libata: drop WARN from protocol error in ata_sff_qc_issue()

ata_sff_qc_issue() expects upper layers to never issue commands on a
command protocol that it doesn't implement.  While the assumption
holds fine with the usual IO path, nothing filters based on the
command protocol in the passthrough path (which was added later),
allowing the warning to be tripped with a passthrough command with the
right (well, wrong) protocol.

Failing with AC_ERR_SYSTEM is the right thing to do anyway.  Remove
the unnecessary WARN.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Link: http://lkml.kernel.org/r/CACT4Y+bXkvevNZU8uP6X0QVqsj6wNoUA_1exfTSOzc+SmUtMOA@mail.gmail.com
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libata-sff.c