]> git.baikalelectronics.ru Git - kernel.git/commit
tracing: Fix user stack trace "??" output
authorEiichi Tsukata <devel@etsukata.com>
Sun, 30 Jun 2019 08:54:38 +0000 (17:54 +0900)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 19 Jul 2019 16:12:39 +0000 (12:12 -0400)
commit1df9c25128f730d4daeeee2df0471a1938f3cc43
tree1a93e6fc39dff137e20e8d756b73e03ad2b318e3
parent82acfc3b66654a4c50b34690ce69d536d36159c8
tracing: Fix user stack trace "??" output

Commit 9064c1754885 ("x86/stacktrace: Remove the pointless ULONG_MAX
marker") removes ULONG_MAX marker from user stack trace entries but
trace_user_stack_print() still uses the marker and it outputs unnecessary
"??".

For example:

            less-1911  [001] d..2    34.758944: <user stack trace>
   =>  <00007f16f2295910>
   => ??
   => ??
   => ??
   => ??
   => ??
   => ??
   => ??

The user stack trace code zeroes the storage before saving the stack, so if
the trace is shorter than the maximum number of entries it can terminate
the print loop if a zero entry is detected.

Link: http://lkml.kernel.org/r/20190630085438.25545-1-devel@etsukata.com
Cc: stable@vger.kernel.org
Fixes: f3a12a13d672 ("tracing: Remove the ULONG_MAX stack trace hackery")
Signed-off-by: Eiichi Tsukata <devel@etsukata.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_output.c