]> git.baikalelectronics.ru Git - kernel.git/commit
devtmpfs: fix placement of complete() call
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Fri, 12 Mar 2021 10:30:26 +0000 (11:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Mar 2021 13:57:35 +0000 (14:57 +0100)
commit1dc38041368b9d0d8ef648bb6bcfa2af981c81f4
tree5e3dc8d3ff2812b407db6e92fb6255fb917e1087
parent5b7779dc3467420d32fcb172d3591d6baefe436a
devtmpfs: fix placement of complete() call

Calling complete() from within the __init function is wrong -
theoretically, the init process could proceed all the way to freeing
the init mem before the devtmpfsd thread gets to execute the return
instruction in devtmpfs_setup().

In practice, it seems to be harmless as gcc inlines devtmpfs_setup()
into devtmpfsd(). So the calls of the __init functions init_chdir()
etc. actually happen from devtmpfs_setup(), but the __ref on that one
silences modpost (it's all right, because those calls happen before
the complete()). But it does make the __init annotation of the setup
function moot, which we'll fix in a subsequent patch.

Fixes: b85e315b4ee3 ("devtmpfs: refactor devtmpfsd()")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Link: https://lore.kernel.org/r/20210312103027.2701413-1-linux@rasmusvillemoes.dk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/devtmpfs.c