]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 27 Oct 2022 01:34:38 +0000 (09:34 +0800)
committerTakashi Iwai <tiwai@suse.de>
Thu, 27 Oct 2022 06:27:39 +0000 (08:27 +0200)
commit1da4379a02f4b2e8afa2f9986bb918cab2afd4ac
tree8500aa6cf1093f42e260ea909c5285fa3949ac1a
parentba2e50941591fbe6f7afedceb5c5cbea9864b0ca
ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()

dev_set_name() in soundbus_add_one() allocates memory for name, it need be
freed when of_device_register() fails, call soundbus_dev_put() to give up
the reference that hold in device_initialize(), so that it can be freed in
kobject_cleanup() when the refcount hit to 0. And other resources are also
freed in i2sbus_release_dev(), so it can return 0 directly.

Fixes: 3f4ff7c5f2ad ("[ALSA] snd-aoa: add snd-aoa")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221027013438.991920-1-yangyingliang@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/aoa/soundbus/i2sbus/core.c