]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: firewire-tascam: Fix integer overflow in midi_port_work()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 11 Jan 2021 13:02:51 +0000 (14:02 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 12 Jan 2021 13:57:38 +0000 (14:57 +0100)
commit1d6dfa5e3bbabad18fe7a57da6b1a4c36178d1a8
tree150f891757378000ecd6e2b281c0e5932e10558b
parent82c58e776c647da739f74e87c6344159339d5346
ALSA: firewire-tascam: Fix integer overflow in midi_port_work()

As snd_fw_async_midi_port.consume_bytes is unsigned int, and
NSEC_PER_SEC is 1000000000L, the second multiplication in

    port->consume_bytes * 8 * NSEC_PER_SEC / 31250

always overflows on 32-bit platforms, truncating the result.  Fix this
by precalculating "NSEC_PER_SEC / 31250", which is an integer constant.

Note that this assumes port->consume_bytes <= 16777.

Fixes: 7c8c2a4ada72d407 ("ALSA: firewire-lib/firewire-tascam: localize async midi port")
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20210111130251.361335-3-geert+renesas@glider.be
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/tascam/tascam-transaction.c