]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "kconfig: qconf: Change title for the item window"
authorMasahiro Yamada <masahiroy@kernel.org>
Wed, 29 Jul 2020 17:46:17 +0000 (02:46 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Sat, 1 Aug 2020 11:54:39 +0000 (20:54 +0900)
commit1d5e85e5b3468cf5214972e033b6a0b0829846ed
treef113179717ea39bb7a219b90d141de3b742e461e
parent76c0ad4bc93e916c778ceda04612dd670a7d1a4f
Revert "kconfig: qconf: Change title for the item window"

This reverts commit 63353ec4b08f968fea9c203ec81a2aeb5ab2e283.

It added dead code to ConfigList:ConfigList().

The constructor of ConfigList has the initializer, mode(singleMode).

    if (mode == symbolMode)
           setHeaderLabels(QStringList() << "Item" << "Name" << "N" << "M" << "Y" << "Value");
    else
           setHeaderLabels(QStringList() << "Option" << "Name" << "N" << "M" << "Y" << "Value");

... always takes the else part.

The change to ConfigList::updateSelection() is strange too.
When you click the split view icon for the first time, the titles in
both windows show "Option". After you click something in the right
window, the title suddenly changes to "Item".

ConfigList::updateSelection() is not the right place to do this,
at least. It was not a good idea, I think.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/qconf.cc