]> git.baikalelectronics.ru Git - kernel.git/commit
thermal/drivers/mediatek: Use devm_of_iomap to avoid resource leak in mtk_thermal_probe
authorKang Chen <void0red@hust.edu.cn>
Wed, 19 Apr 2023 02:07:48 +0000 (10:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:03:37 +0000 (23:03 +0900)
commit1c221aee8d40ef2a27de0c1d42225dc83feb1b4e
tree676262c53eafbe16f1c9f56746785e324a1bb1a2
parent55183962e0e7ccdbc5bde56bfad1b50e8e50b1d6
thermal/drivers/mediatek: Use devm_of_iomap to avoid resource leak in mtk_thermal_probe

[ Upstream commit f05c7b7d9ea9477fcc388476c6f4ade8c66d2d26 ]

Smatch reports:
1. mtk_thermal_probe() warn: 'apmixed_base' from of_iomap() not released.
2. mtk_thermal_probe() warn: 'auxadc_base' from of_iomap() not released.

The original code forgets to release iomap resource when handling errors,
fix it by switch to devm_of_iomap.

Fixes: cd8332e632d0 ("thermal: mediatek: Add tsensor support for V2 thermal system")
Signed-off-by: Kang Chen <void0red@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230419020749.621257-1-void0red@hust.edu.cn
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/thermal/mtk_thermal.c