]> git.baikalelectronics.ru Git - kernel.git/commit
btrfs: don't set lock_owner when locking extent buffer for reading
authorZygo Blaxell <ce3g8jdj@umail.furryterror.org>
Thu, 9 Jun 2022 02:39:36 +0000 (22:39 -0400)
committerDavid Sterba <dsterba@suse.com>
Tue, 21 Jun 2022 12:46:56 +0000 (14:46 +0200)
commit1be343299f7dfae55a5c87bd7f77315ad3148d12
treed3ea384f0d9c7f1e1a6ef2519e5741ab9fd25f2f
parent4c9f2a9596dd0c3ccfe6f2495bb65ab80d40ca2e
btrfs: don't set lock_owner when locking extent buffer for reading

In a6c4dbd3e3c7 "btrfs: switch extent buffer tree lock to rw_semaphore"
the functions for tree read locking were rewritten, and in the process
the read lock functions started setting eb->lock_owner = current->pid.
Previously lock_owner was only set in tree write lock functions.

Read locks are shared, so they don't have exclusive ownership of the
underlying object, so setting lock_owner to any single value for a
read lock makes no sense.  It's mostly harmless because write locks
and read locks are mutually exclusive, and none of the existing code
in btrfs (btrfs_init_new_buffer and print_eb_refs_lock) cares what
nonsense is written in lock_owner when no writer is holding the lock.

KCSAN does care, and will complain about the data race incessantly.
Remove the assignments in the read lock functions because they're
useless noise.

Fixes: a6c4dbd3e3c7 ("btrfs: switch extent buffer tree lock to rw_semaphore")
CC: stable@vger.kernel.org # 5.15+
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/locking.c