]> git.baikalelectronics.ru Git - kernel.git/commit
virtio-net: fix race between ndo_open() and virtio_device_ready()
authorJason Wang <jasowang@redhat.com>
Fri, 17 Jun 2022 07:29:49 +0000 (15:29 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 27 Jun 2022 12:02:59 +0000 (08:02 -0400)
commit1bd3b0f043231c6e1185977ffee80e60f096eb0a
treed31a4d46395675b1e007389063beb794bf910d2d
parentcd3e5ea0b14e9ccbf38b9ac927becb356dba58cf
virtio-net: fix race between ndo_open() and virtio_device_ready()

We currently call virtio_device_ready() after netdev
registration. Since ndo_open() can be called immediately
after register_netdev, this means there exists a race between
ndo_open() and virtio_device_ready(): the driver may start to use the
device before DRIVER_OK which violates the spec.

Fix this by switching to use register_netdevice() and protect the
virtio_device_ready() with rtnl_lock() to make sure ndo_open() can
only be called after virtio_device_ready().

Fixes: c0110892800dd ("virtio_net: enable VQs early")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20220617072949.30734-1-jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/net/virtio_net.c