]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: fix potential use after free in __ext4_journal_stop
authorLukas Czerner <lczerner@redhat.com>
Sun, 18 Oct 2015 02:57:06 +0000 (22:57 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 18 Oct 2015 02:57:06 +0000 (22:57 -0400)
commit1bcbf31281aa3a7a25a1fc3c1ec92a16560d9062
treea7d5770b2fbd3961c40b6bb2da86873dcfab19c0
parenta56361d1f13b0cdffccf3717b8fa57b1411b7347
ext4: fix potential use after free in __ext4_journal_stop

There is a use-after-free possibility in __ext4_journal_stop() in the
case that we free the handle in the first jbd2_journal_stop() because
we're referencing handle->h_err afterwards. This was introduced in
8426e137a165805af1655310a36559c58c0649e3 and it is wrong. Fix it by
storing the handle->h_err value beforehand and avoid referencing
potentially freed handle.

Fixes: 8426e137a165805af1655310a36559c58c0649e3
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Cc: stable@vger.kernel.org
fs/ext4/ext4_jbd2.c