]> git.baikalelectronics.ru Git - kernel.git/commit
psi: Fix a division error in psi poll()
authorJohannes Weiner <hannes@cmpxchg.org>
Tue, 3 Dec 2019 18:35:24 +0000 (13:35 -0500)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 17 Dec 2019 12:32:48 +0000 (13:32 +0100)
commit1bb2dd987556ccd2480de5a5878a8a826c45db7c
tree2c5ed57633fc8461c1ba1c938e271c1f137bd8ae
parente64feec881b12273467ae6b91d0f42404fe18dbb
psi: Fix a division error in psi poll()

The psi window size is a u64 an can be up to 10 seconds right now,
which exceeds the lower 32 bits of the variable. We currently use
div_u64 for it, which is meant only for 32-bit divisors. The result is
garbage pressure sampling values and even potential div0 crashes.

Use div64_u64.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Cc: Jingfeng Xie <xiejingfeng@linux.alibaba.com>
Link: https://lkml.kernel.org/r/20191203183524.41378-3-hannes@cmpxchg.org
kernel/sched/psi.c