]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: moxart: fix probe logic
authorArnd Bergmann <arnd@arndb.de>
Tue, 3 Feb 2015 15:55:54 +0000 (16:55 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 4 Feb 2015 08:42:29 +0000 (09:42 +0100)
commit1a9e367c740bc5f1c2744a59d6ecd134d5cd978e
treec7c43a53c07d85fe91eabe9dc508b191e256df8b
parent8fc3d31f42b851b69ece47a0b0af59f7cbcd8b64
mmc: moxart: fix probe logic

Jonas Jensen wanted to submit a patch for these, but apparently
forgot about it. I stumbled over this symptom first:

drivers/built-in.o: In function `moxart_probe':
:(.text+0x2af128): undefined reference to `of_dma_request_slave_channel'

This is because of_dma_request_slave_channel is an internal helper
and not exported to loadable module. I'm changing the driver to
use dma_request_slave_channel_reason() instead.

Further problems from inspection:

* The remove function must not call kfree on the host pointer,
  because it is allocated together with the mmc_host.

* The clock is never released

* The dma_cap_mask_t is completely unused and can be removed

* deferred probing does not work if the dma driver is loaded
  after the mmc driver.

This patch should fix all of the above.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/moxart-mmc.c