]> git.baikalelectronics.ru Git - kernel.git/commit
drm/msm/dsi: don't powerup at modeset time for parade-ps8640
authorDouglas Anderson <dianders@chromium.org>
Fri, 13 May 2022 20:15:13 +0000 (13:15 -0700)
committerRob Clark <robdclark@chromium.org>
Wed, 18 May 2022 17:51:42 +0000 (10:51 -0700)
commit1a7bbeadee81dc8bff9bf8429d7b097c8734bc3c
tree611c6b5613bbaf88365d24e52b219b014cfffeda
parent1eda552f033e3539ed352ae70c58d29c6ea9ff7b
drm/msm/dsi: don't powerup at modeset time for parade-ps8640

Commit a3e3f84853af ("drm/msm/dsi: move DSI host powerup to modeset
time") caused sc7180 Chromebooks that use the parade-ps8640 bridge
chip to fail to turn the display back on after it turns off.

Unfortunately, it doesn't look easy to fix the parade-ps8640 driver to
handle the new power sequence. The Linux driver has almost nothing in
it and most of the logic for this bridge chip is in black-box firmware
that the bridge chip uses.

Also unfortunately, reverting the patch will break "tc358762".

The long term solution here is probably Dave Stevenson's series [1]
that would give more flexibility. However, that is likely not a quick
fix.

For the short term, we'll look at the compatible of the next bridge in
the chain and go back to the old way for the Parade PS8640 bridge
chip. If it's found that other bridge chips also need this workaround
then we can add them to the list or consider inverting the
condition. However, the hope is that the framework will not take too
much longer to land and we won't have to add anything other than
ps8640 here.

[1] https://lore.kernel.org/r/cover.1646406653.git.dave.stevenson@raspberrypi.com

Fixes: a3e3f84853af ("drm/msm/dsi: move DSI host powerup to modeset time")
Suggested-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Link: https://lore.kernel.org/r/20220513131504.v5.1.Ia196e35ad985059e77b038a41662faae9e26f411@changeid
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/dsi/dsi_manager.c