]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: interface: use timeu64_t for range_max
authorEmmanuel Nicolet <emmanuel.nicolet@gmail.com>
Fri, 27 Sep 2019 11:04:46 +0000 (13:04 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 3 Oct 2019 19:55:17 +0000 (21:55 +0200)
commit19e4de774345fd73af5d854e78d57ab9acec7921
tree85341021e9cd0a92945a1431d530e6f4558ce172
parent4a8bd22abc8cea260a88b6ac6fa33ffd515e463e
rtc: interface: use timeu64_t for range_max

For rtc drivers where rtc->range_max is set U64_MAX, like the PS3 rtc,
rtc_valid_range() always returns -ERANGE. This is because the local
variable range_max has type time64_t, so the test
if (time < range_min || time > range_max)
return -ERANGE;
becomes (time < range_min || time > -1), which always evaluates to true.
timeu64_t should be used, since it's the type of rtc->range_max.

Signed-off-by: Emmanuel Nicolet <emmanuel.nicolet@gmail.com>
Link: https://lore.kernel.org/r/20190927110446.GA6289@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/interface.c