]> git.baikalelectronics.ru Git - kernel.git/commit
net/irda: remove pointless assignment/check
authorVegard Nossum <vegard.nossum@oracle.com>
Fri, 19 Aug 2016 16:08:57 +0000 (18:08 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 20 Aug 2016 01:07:24 +0000 (18:07 -0700)
commit193b2d9159b3e3a9633357b98d089e18e8fdb5a9
tree6d061b425568ebd158e24a176af37e225023f3fc
parent327a0416bea44f004d7ee138d51f9eee089ac9dd
net/irda: remove pointless assignment/check

We've already set sk to sock->sk and dereferenced it, so if it's NULL
we would have crashed already. Moreover, if it was NULL we would have
crashed anyway when jumping to 'out' and trying to unlock the sock.
Furthermore, if we had assigned a different value to 'sk' we would
have been calling lock_sock() and release_sock() on different sockets.

My conclusion is that these two lines are complete nonsense and only
serve to confuse the reader.

Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/irda/af_irda.c