]> git.baikalelectronics.ru Git - kernel.git/commit
auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()
authorJianglei Nie <niejianglei2021@163.com>
Tue, 29 Nov 2022 08:15:42 +0000 (16:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:55:16 +0000 (13:55 +0100)
commit190d47cb7820303a879a1f850a990a363022762a
tree02c5c62d817077f3634048e80f71ce45a5dc03f5
parentb351e1d7bdc8f8975e66cf516c17ac509cb6dbb8
auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()

[ Upstream commit 0970e666d044b2b534b82baf545e0145f9ef4404 ]

hd44780_probe() allocates a memory chunk for hd with kzalloc() and
makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(),
we should release all relevant memory and resource. But "lcd->drvdata
->hd44780" is not released, which will lead to a memory leak.

We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix
the memory leak bug.

Fixes: c7841577321a ("auxdisplay: Introduce hd44780_common.[ch]")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/auxdisplay/hd44780.c