]> git.baikalelectronics.ru Git - kernel.git/commit
iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_config_word()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thu, 26 Jan 2023 15:36:09 +0000 (07:36 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:55:35 +0000 (13:55 +0100)
commit1838456550884ee1d3394006e0c3caed2a2bb845
tree4ee5dd2c6930bbcf29f175f3bfaeb0c56b551a0a
parent5723ffffebb19467748ff7fc48dddb8e107fd818
iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_config_word()

[ Upstream commit 48d18f1440653ddf4176576b82f800c61691c357 ]

Smatch Warns:
drivers/iio/accel/mma9551_core.c:299
mma9551_read_config_word() error: uninitialized symbol 'v'.

When (offset >= 1 << 12) is true mma9551_transfer() will return -EINVAL
without 'v' being initialized, so check for the error and return.

Note: No actual bug as caller checks the return value and does not
use the parameter in the problem case.

Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230126153610.3586243-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/accel/mma9551_core.c