]> git.baikalelectronics.ru Git - kernel.git/commit
platform/x86: pcengines-apuv2: revert wiring up simswitch GPIO as LED
authorFlorian Eckert <fe@dev.tdt.de>
Mon, 13 Jul 2020 08:50:10 +0000 (10:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Aug 2021 06:56:58 +0000 (08:56 +0200)
commit17afc64eab7c1447495bdaa5a61e5ef0d464a688
tree8a9aa377f274ccd42e94b940814bafe56c33854d
parent1db39b946ab263f81eb0db3cc7aced939670a1aa
platform/x86: pcengines-apuv2: revert wiring up simswitch GPIO as LED

[ Upstream commit f560cd502190a9fd0ca8db0a15c5cca7d9091d2c ]

This reverts commit a513a92cf7932e930cced43c6efb09e43f4ee251.

Explanation why this does not work:
This change connects the simswap to the LED subsystem of the kernel.
From my point of view, it's nonsense. If we do it this way, then this
can be switched relatively easily via the LED subsystem (trigger:
none/default-on) and that is dangerous! If this is used, it would be
unfavorable, since there is also another trigger (trigger:
heartbeat/netdev).

Therefore, this simswap GPIO should remain in the GPIO
subsystem and be switched via it and not be connected to the LED
subsystem. To avoid the problems mentioned above. The LED subsystem is
not made for this and it is not a good compromise, but rather dangerous.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/pcengines-apuv2.c