]> git.baikalelectronics.ru Git - kernel.git/commit
sysctl: Fix data races in proc_dointvec_jiffies().
authorKuniyuki Iwashima <kuniyu@amazon.com>
Wed, 6 Jul 2022 23:39:57 +0000 (16:39 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Jul 2022 19:24:20 +0000 (21:24 +0200)
commit1780009b80906bb21247e8032c2b94588dc5d483
tree43df6d61ee9ed59fc944a77042ed29f6663fef04
parentdd87ecd6ddf5275f3305e40a00bb0154829ea4eb
sysctl: Fix data races in proc_dointvec_jiffies().

[ Upstream commit fc1363ca1d0e0a1d3239eb192a02fbcd222c6d0c ]

A sysctl variable is accessed concurrently, and there is always a chance
of data-race.  So, all readers and writers need some basic protection to
avoid load/store-tearing.

This patch changes proc_dointvec_jiffies() to use READ_ONCE() and
WRITE_ONCE() internally to fix data-races on the sysctl side.  For now,
proc_dointvec_jiffies() itself is tolerant to a data-race, but we still
need to add annotations on the other subsystem's side.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/sysctl.c