]> git.baikalelectronics.ru Git - kernel.git/commit
drm: atmel-hlcdc: enable clock before configuring timing engine
authorClaudiu Beznea <claudiu.beznea@microchip.com>
Wed, 18 Dec 2019 12:28:25 +0000 (14:28 +0200)
committerSam Ravnborg <sam@ravnborg.org>
Mon, 6 Jan 2020 18:53:24 +0000 (19:53 +0100)
commit16eeaa0da64b3f92a93c40d6c845bd4a52f1d91a
treee2fad7a955a15abfe1a7abc2d5a90eb2abfc30a2
parent740604bd4f8c4abb795db84f05c4b5c1bdd54b9c
drm: atmel-hlcdc: enable clock before configuring timing engine

Changing pixel clock source without having this clock source enabled
will block the timing engine and the next operations after (in this case
setting ATMEL_HLCDC_CFG(5) settings in atmel_hlcdc_crtc_mode_set_nofb()
will fail). It is recomended (although in datasheet this is not present)
to actually enabled pixel clock source before doing any changes on timing
enginge (only SAM9X60 datasheet specifies that the peripheral clock and
pixel clock must be enabled before using LCD controller).

Fixes: 6039b0d28632 ("drm: add Atmel HLCDC Display Controller support")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: <stable@vger.kernel.org> # v4.0+
Link: https://patchwork.freedesktop.org/patch/msgid/1576672109-22707-3-git-send-email-claudiu.beznea@microchip.com
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c